Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jax cli #1881

Merged
merged 9 commits into from Jan 20, 2022
Merged

Jax cli #1881

merged 9 commits into from Jan 20, 2022

Conversation

priyanshuone6
Copy link
Member

@priyanshuone6 priyanshuone6 commented Jan 1, 2022

  • Add __init__
  • Add --help in pybamm_install_jax
  • Add an option to force install compatible versions of jax and jaxlib if already installed using cli

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just some style comments

pybamm/util.py Outdated Show resolved Hide resolved
pybamm/util.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #1881 (54c206c) into develop (393ff5d) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1881      +/-   ##
===========================================
+ Coverage    99.28%   99.31%   +0.03%     
===========================================
  Files          345      346       +1     
  Lines        19119    19105      -14     
===========================================
- Hits         18983    18975       -8     
+ Misses         136      130       -6     
Impacted Files Coverage Δ
pybamm/util.py 100.00% <100.00%> (ø)
pybamm/version.py 100.00% <0.00%> (ø)
pybamm/__init__.py 100.00% <0.00%> (+5.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393ff5d...54c206c. Read the comment docs.

@valentinsulzer
Copy link
Member

What are the lines that lost coverage?

@priyanshuone6
Copy link
Member Author

Not sure on why this is happening. Might be due to adding few init files?

@Saransh-cpp
Copy link
Member

Looks like adding an __init__.py to the models/full_battery_models/lithium_metal directory exposed dfn.py to coverage.

@valentinsulzer
Copy link
Member

Does there have to be an __init__.py in that folder right now? Can you open an issue to add the test?

@Saransh-cpp
Copy link
Member

I don't think it is needed, as pybamm doesn't offer the lithium_metal models right now?

@priyanshuone6
Copy link
Member Author

Should I remove the init file from lithium_metal?

@valentinsulzer
Copy link
Member

Yes, thanks

@valentinsulzer valentinsulzer merged commit 04bb8bf into pybamm-team:develop Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants