Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameter path bug in windows #1900

Merged

Conversation

Saransh-cpp
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #1804

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Saransh-cpp Saransh-cpp marked this pull request as draft January 14, 2022 09:53
@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #1900 (934336c) into develop (25ceb5f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1900   +/-   ##
========================================
  Coverage    99.28%   99.28%           
========================================
  Files          345      345           
  Lines        19108    19116    +8     
========================================
+ Hits         18972    18980    +8     
  Misses         136      136           
Impacted Files Coverage Δ
pybamm/parameters/parameter_values.py 99.46% <100.00%> (+<0.01%) ⬆️
pybamm/util.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25ceb5f...934336c. Read the comment docs.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Saransh-cpp Saransh-cpp marked this pull request as ready for review January 15, 2022 07:54
@valentinsulzer valentinsulzer merged commit 751c18d into pybamm-team:develop Jan 16, 2022
@Saransh-cpp Saransh-cpp deleted the issue-1804-parameterization branch January 16, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameterization issue
2 participants