I1906 solution json #1909
Merged
I1906 solution json #1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1909 +/- ##
========================================
Coverage 99.32% 99.32%
========================================
Files 346 346
Lines 19121 19135 +14
========================================
+ Hits 18992 19006 +14
Misses 129 129
Continue to review full report at Codecov.
|
valentinsulzer
approved these changes
Jan 21, 2022
|
|
||
| # check if string has the right values | ||
| json_data = json.loads(json_str) | ||
| np.testing.assert_array_almost_equal(json_data["c"], solution.data["c"]) |
There was a problem hiding this comment.
why is it only almost equal?
There was a problem hiding this comment.
I was only copying the other lines of this test. But it would need to be almost equal, as the numbers (e.g. 1/3) will be rounded off when they are written to json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Solution.save_data()to return a string if filename is Noneto_formatof jsonFixes #1906
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: