Fix minor bugs in install_odes.py
#1916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1916 +/- ##
========================================
Coverage 99.32% 99.32%
========================================
Files 346 346
Lines 18981 18981
========================================
Hits 18853 18853
Misses 128 128 Continue to review full report at Codecov.
|
|
Turns out the installation link has been changed too😅 |
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| ## Bug fixes | |||
|
|
|||
| - `scikit.odes` and `SUNDIALS` can now be installed using `pybamm_install_odes` ([#1916](https://github.com/pybamm-team/PyBaMM/pull/1916)) | |||
There was a problem hiding this comment.
Could you merge develop and move this to the unreleased section
…fix-install_odes
Saransh-cpp
force-pushed
the
fix-install_odes
branch
from
70d3cf9
to
22e92e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The installation script doesn't work currently, plus there were some documentation errors.
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: