Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 1129 julia #1942

Merged
merged 59 commits into from May 26, 2022
Merged

Issue 1129 julia #1942

merged 59 commits into from May 26, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Some basic functionality for generating PyBaMM expression trees in Julia. The code is pretty horrible, but it's a start

Fixes #1129

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer
#1129 revert deletions
4ac20b6
@valentinsulzer
Revert "use tox.ini and setup.py from develop branch"
56035b1 
This reverts commit 5916134.
@valentinsulzer
udpate tox.ini
aecfcea
@valentinsulzer
#1129 test fix
c327e7e
@valentinsulzer
#1129 fix some tests
001553e
@valentinsulzer
Merge branch 'develop' into issue-1129-julia
64ed751
@valentinsulzer
#1129 minor refactorings
43132df
@valentinsulzer
#1129 merge develop
088f0ca
@valentinsulzer
Merge branch 'develop' into issue-1129-julia
d8f8911
@valentinsulzer
#1129 merge develop
1237c16
@valentinsulzer
#1129 merge develop
ebb5d3f
@valentinsulzer
fix no domain issue
f1d4985
@valentinsulzer
#1129 merge develop
fc2b1c6
@valentinsulzer
#1129 fix julia tests
0050d42
@valentinsulzer
#1129 skip julia on windows and python3.9
d7dc913
@valentinsulzer
#1129 don't install julia on ubuntu wuth python 3.9
d99a2f8
@valentinsulzer
Merge branch 'develop' into issue-1129-julia
2090c62
@valentinsulzer
Merge branch 'develop' into issue-1129-julia
313e118
@valentinsulzer
merge develop
0ad500a
@valentinsulzer
#1129 merge develop
904c5e0
@valentinsulzer
Merge branch 'develop' into issue-1129-julia
c0aee07
@valentinsulzer
#1129 fix julia generation for discretized equations
61b6f13
@valentinsulzer
#1129 fix mtk model generation
802966d
@valentinsulzer
#1129 merge develop
3774e28
@valentinsulzer
fix mtk for spme
5f5e006
@valentinsulzer
merge develop
d87761a
@valentinsulzer
Merge branch 'averages-class' into issue-1129-julia
6a025eb
@valentinsulzer
Merge branch 'averages-class' into issue-1129-julia
52644bb
@valentinsulzer
#1129 fix print_names
a12a967
@valentinsulzer
Merge branch 'develop' into issue-1129-julia
7148413
@valentinsulzer valentinsulzer marked this pull request as ready for review March 15, 2022 23:20
martinjrobins
martinjrobins approved these changes Mar 28, 2022
View reviewed changes
Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @tinosulzer , some minor comments below

pybamm/expression_tree/operations/evaluate_julia.py Outdated Show resolved Hide resolved
tests/unit/test_models/test_base_model_generate_julia_diffeq.py Show resolved Hide resolved
tests/unit/test_solvers/test_julia_mtk.py Outdated Show resolved Hide resolved
Saransh-cpp
Saransh-cpp reviewed Mar 29, 2022
View reviewed changes
pybamm/util.py Outdated Show resolved Hide resolved
brosaplanella
brosaplanella approved these changes Mar 29, 2022
View reviewed changes
Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Tino!

pybamm/expression_tree/operations/evaluate_julia.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
brosaplanella
brosaplanella reviewed Apr 22, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@valentinsulzer valentinsulzer merged commit 0ce0a71 into develop May 26, 2022
@valentinsulzer valentinsulzer deleted the issue-1129-julia branch May 26, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brosaplanella brosaplanella brosaplanella approved these changes

@Saransh-cpp Saransh-cpp Saransh-cpp left review comments

@martinjrobins martinjrobins martinjrobins approved these changes

@rtimms rtimms Awaiting requested review from rtimms rtimms is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate Julia code from a pybamm expression tree
4 participants
@valentinsulzer @martinjrobins @brosaplanella @Saransh-cpp