Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add experiment benchmarks #2106

Merged

Conversation

Vaibhav-Chopra-GT
Copy link
Contributor

Description

Added benchmarks for CCCV and GITT experiments for SPM and DFN models with Chen2020 and Marquis2019 parameter sets

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #2106 (e90646c) into develop (d0f8f35) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2106   +/-   ##
========================================
  Coverage    99.38%   99.38%           
========================================
  Files          348      348           
  Lines        19234    19234           
========================================
  Hits         19115    19115           
  Misses         119      119           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0f8f35...e90646c. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 9ec6ebc into pybamm-team:develop Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants