add degradation models benchmarks #2132
Conversation
|
You should name them based on the option e.g. |
Codecov Report
@@ Coverage Diff @@
## develop #2132 +/- ##
===========================================
- Coverage 99.38% 99.35% -0.03%
===========================================
Files 352 356 +4
Lines 19289 19357 +68
===========================================
+ Hits 19170 19233 +63
- Misses 119 124 +5
Continue to review full report at Codecov.
|
benchmarks/degredation_models.py
Outdated
| pybamm.standard_spatial_vars.x_n: 20, | ||
| pybamm.standard_spatial_vars.x_s: 20, | ||
| pybamm.standard_spatial_vars.x_p: 20, | ||
| pybamm.standard_spatial_vars.r_n: 30, |
There was a problem hiding this comment.
Are you using 30 in the particles for some reason (e.g. convergence)? Otherwise might be better to keep the default (20).
benchmarks/degredation_models.py
Outdated
| @@ -0,0 +1,549 @@ | |||
| import pybamm | |||
There was a problem hiding this comment.
Small typo in the filename (degredation instead of degradation).
benchmarks/degredation_models.py
Outdated
| param.process_model(self.model) | ||
| param.process_geometry(geometry) | ||
|
|
||
| # set mesh |
There was a problem hiding this comment.
Can these lines be replaced by compute_discretisation? (It appears multiple times below, so not repeating the comment)
|
how long does it take to run now? |
15 minutes |
Description
Added benchmarks for degradation models for SPM and DFN (build, simulate, solve) for each model option by adding model values and model as params.
Also, what should I name them?
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: