Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster electrode soh #2210

Merged
merged 6 commits into from Sep 12, 2022
Merged

Faster electrode soh #2210

merged 6 commits into from Sep 12, 2022

Conversation

valentinsulzer
Copy link
Member

Description

Speed up calculations for electrode SOH

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer marked this pull request as draft August 2, 2022 17:45
@codecov
Copy link

codecov bot commented Sep 7, 2022

Codecov Report

Merging #2210 (2c60416) into develop (dbdd188) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2210   +/-   ##
========================================
  Coverage    99.39%   99.40%           
========================================
  Files          364      364           
  Lines        19996    20021   +25     
========================================
+ Hits         19876    19901   +25     
  Misses         120      120           
Impacted Files Coverage Δ
pybamm/simulation.py 98.86% <ø> (ø)
...s/full_battery_models/lithium_ion/electrode_soh.py 100.00% <100.00%> (ø)
pybamm/solvers/base_solver.py 100.00% <100.00%> (ø)
pybamm/solvers/solution.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@valentinsulzer valentinsulzer marked this pull request as ready for review September 10, 2022 00:55
Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit f9fe319 into develop Sep 12, 2022
@valentinsulzer valentinsulzer deleted the faster-electrode-soh branch September 12, 2022 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants