Added throughput variables for degradation sudies - #2249
Merged
Merged
Conversation
added 4 commits
August 15, 2022 16:01
…te discharge energy' is false
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Member
|
did you mean to add all of these additional files (coupled_degradation.ipynb, etc)? |
Codecov Report
@@ Coverage Diff @@
## develop #2249 +/- ##
========================================
Coverage 99.36% 99.36%
========================================
Files 355 357 +2
Lines 19499 19524 +25
========================================
+ Hits 19375 19400 +25
Misses 124 124
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
added 2 commits
August 18, 2022 16:07
…OKane2022 parameters
Contributor
Author
|
I did mean to add lipf6_OKane2022, yes. I should have done this in the same PR as SEi on cracks but forgot! coupled_degradation has been removed. I do want to add it eventually but there's still a lot of debugging to do. |
valentinsulzer
approved these changes
Aug 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added new cumulative variables "Throughput capacity [A.h]" and "Throughput energy [W.h]" to standard variables and summary variables. "Time [s]" and "Time [h]" are also now summary variables. This is designed to make it easier to conduct degradation studies using the save_at_cycles feature.
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: