Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added throughput variables for degradation sudies #2249

Merged
merged 10 commits into from
Aug 19, 2022

Conversation

DrSOKane
Copy link
Contributor

Description

Added new cumulative variables "Throughput capacity [A.h]" and "Throughput energy [W.h]" to standard variables and summary variables. "Time [s]" and "Time [h]" are also now summary variables. This is designed to make it easier to conduct degradation studies using the save_at_cycles feature.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@valentinsulzer
Copy link
Member

did you mean to add all of these additional files (coupled_degradation.ipynb, etc)?

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #2249 (7a1f46b) into develop (1928105) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop    #2249   +/-   ##
========================================
  Coverage    99.36%   99.36%           
========================================
  Files          355      357    +2     
  Lines        19499    19524   +25     
========================================
+ Hits         19375    19400   +25     
  Misses         124      124           
Impacted Files Coverage Δ
...m/models/full_battery_models/base_battery_model.py 99.76% <ø> (ø)
...ttery_models/lithium_ion/base_lithium_ion_model.py 100.00% <ø> (ø)
pybamm/parameters/parameter_sets.py 100.00% <ø> (ø)
...22/electrolyte_conductivity_Nyman2008_arrhenius.py 100.00% <100.00%> (ø)
...022/electrolyte_diffusivity_Nyman2008_arrhenius.py 100.00% <100.00%> (ø)
pybamm/models/standard_variables.py 100.00% <100.00%> (ø)
...ubmodels/external_circuit/base_external_circuit.py 100.00% <100.00%> (ø)
pybamm/models/submodels/interface/sei/base_sei.py 100.00% <100.00%> (ø)
...ybamm/models/submodels/interface/sei/sei_growth.py 100.00% <100.00%> (ø)
pybamm/parameters/lithium_ion_parameters.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@DrSOKane
Copy link
Contributor Author

I did mean to add lipf6_OKane2022, yes. I should have done this in the same PR as SEi on cracks but forgot!

coupled_degradation has been removed. I do want to add it eventually but there's still a lot of debugging to do.

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but the tests aren't running (edit: managed to trigger)

@valentinsulzer valentinsulzer merged commit a1bc678 into pybamm-team:develop Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants