Repository navigation
Fix colab and pybtex issue - #2526
Merged
Merged
Conversation
Codecov ReportBase: 99.72% // Head: 99.72% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2526 +/- ##
========================================
Coverage 99.72% 99.72%
========================================
Files 268 268
Lines 19311 19315 +4
========================================
+ Hits 19258 19262 +4
Misses 53 53
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Co-authored-by: Valentin Sulzer <valentinsulzer@hotmail.com>
valentinsulzer
approved these changes
Dec 5, 2022
valentinsulzer
left a comment
Member
There was a problem hiding this comment.
Looks good thanks! Will merge when tests pass
| pybamm.print_citations("test_citations.txt", "bad format") | ||
|
|
||
| # google colab issue - https://github.com/pybamm-team/PyBaMM/issues/2524 | ||
| sys.modules["google.colab"] = "mock" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This looks like this right now -
Now that I think of it, it might be better to not show a warning on importing pybamm (would be too noisy). Rather, we could do -
and then -
Fixes #2524
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: