Add tags to Experiment
#2593
Add tags to Experiment
#2593
Conversation
…yBaMM into issue-2538-tag-experiments
|
At the moment we are not using the |
Codecov ReportBase: 99.69% // Head: 99.69% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #2593 +/- ##
========================================
Coverage 99.69% 99.69%
========================================
Files 271 271
Lines 19540 19560 +20
========================================
+ Hits 19480 19500 +20
Misses 60 60
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…yBaMM into issue-2538-tag-experiments
| @@ -440,3 +454,16 @@ def is_cccv(self, step, next_step): | |||
| if op["events"] == {k: v for k, v in next_op.items() if k in op["events"]}: | |||
| return True | |||
| return False | |||
|
|
|||
| def search_tag(self, tag): | |||
There was a problem hiding this comment.
seems like this should use the "tags" entry of the dictionary?
There was a problem hiding this comment.
That was my original idea, but then I couldn't find a clear mapping between operating_conditions and the actual cycle number. Going forward, when we implement #2322, that will have to be addressed and will make more sense to use the dictionary. But for the time being, processing the strings is fast enough.
Description
Tags can be added to the end of an experiment as
[tag1,tag2]. I have added the methodsearch_tagwhich returns the list of cycles with a certain tag, which should help saving only certain cycles.Fixes #2538
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: