change success to final time

[valentinsulzer]

Description

This enables using algebraic models with step currents. There might have been a good reason to have a different termination, but I don't remember it.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Base: 99.69% // Head: 99.69% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (938ff95) compared to base (9f8d315).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2613      +/-   ##
===========================================
- Coverage    99.69%   99.69%   -0.01%     
===========================================
  Files          271      271              
  Lines        19573    19571       -2     
===========================================
- Hits         19513    19511       -2     
  Misses          60       60              

Impacted Files	Coverage Δ
pybamm/solvers/base_solver.py	100.00% <ø> (ø)
pybamm/solvers/casadi_algebraic_solver.py	100.00% <ø> (ø)
pybamm/solvers/solution.py	100.00% <ø> (ø)
pybamm/solvers/algebraic_solver.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[brosaplanella]

Looks good, thanks! I guess that problems that use algebraic solvers might not have time in them so success made more sense, but if this enables more functionality let's go for it.