Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update effective conductivity #2638

Merged
merged 2 commits into from Jan 31, 2023
Merged

update effective conductivity #2638

merged 2 commits into from Jan 31, 2023

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Jan 30, 2023

Description

Fixes a bug where the solid phase conductivity was double-corrected for tortuosity when creating parameters from a BPX file. The BPX file already contains the effective conductivity, so no correction needs to be applied (hence we set the Bruggeman coefficient to 0). This same bug was present in the Chen2020 parameter sets.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@brosaplanella brosaplanella merged commit 0c120de into develop Jan 31, 2023
@brosaplanella brosaplanella deleted the effective-conductivity branch January 31, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants