Remove conditional for scaling of r-R plots

[iatzak]

Description

Removing hard-coded value of 1 for first_length_scale of r-R plots, which made the x axis of these plots be scaled by 1e5.

Fixes #2225

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ pre-commit run
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Base: 99.69% // Head: 99.69% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (d61b36b) compared to base (d218aa4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2663      +/-   ##
===========================================
- Coverage    99.69%   99.69%   -0.01%     
===========================================
  Files          271      271              
  Lines        19571    19569       -2     
===========================================
- Hits         19511    19509       -2     
  Misses          60       60              

Impacted Files	Coverage Δ
pybamm/solvers/processed_variable.py	100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[valentinsulzer]

Can you update changelog please?

[iatzak]

@tinosulzer I do not understand why such a test (test_compare_SPMe_silicon_graphite) fails, given that

1. running test_compare_outputs_two_phase.py does not touch the code I modified
2. in the other workflow run (before my changelog commit), this same test passed in macOS (?), but failed in Ubuntu

The error is a convergence fail during an integration in the CasADi solver. This is a very general question, but do you have an idea of what's causing this, considering my change to the code?

[valentinsulzer]

It's not related to your changes, it's an intermittent test failure that only happens sometimes on GitHub actions and never locally so is really hard to debug. We're just ignoring it for now ...

[valentinsulzer]

@all-contributors add @iatzak for bugs, code

[allcontributors]

@tinosulzer

I've put up a pull request to add @iatzak! 🎉