Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputParameter in variable bounds #2795

Merged
merged 2 commits into from
Mar 22, 2023
Merged

InputParameter in variable bounds #2795

merged 2 commits into from
Mar 22, 2023

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Mar 21, 2023

Description

If variable bounds contain an InputParameter set the bound to +/- inf.

Fixes #2793

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e59bb51) 99.68% compared to head (fca4dea) 99.68%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2795   +/-   ##
========================================
  Coverage    99.68%   99.68%           
========================================
  Files          272      272           
  Lines        19024    19031    +7     
========================================
+ Hits         18965    18972    +7     
  Misses          59       59           
Impacted Files Coverage Δ
pybamm/discretisations/discretisation.py 99.78% <100.00%> (+<0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@rtimms rtimms merged commit c36c2bd into develop Mar 22, 2023
@rtimms rtimms deleted the issue-2793-input-bounds branch March 22, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error if variable bounds contain an InputParameter
2 participants