Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 2670 interp2d #2907

Merged
merged 16 commits into from Apr 30, 2023
Merged

Issue 2670 interp2d #2907

merged 16 commits into from Apr 30, 2023

Conversation

valentinsulzer
Copy link
Member

Description

Fixes the interp2d warning by switching to using xarray as the backend for ProcessedVariable

Fixes #2760
Fixes #2366

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.01 ⚠️

Comparison is base (9b4490b) 99.69% compared to head (9ebbb11) 99.68%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2907      +/-   ##
===========================================
- Coverage    99.69%   99.68%   -0.01%     
===========================================
  Files          273      273              
  Lines        19086    19009      -77     
===========================================
- Hits         19027    18950      -77     
  Misses          59       59              
Impacted Files Coverage Δ
pybamm/solvers/processed_variable.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Sponsor Member

@brosaplanella brosaplanella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@valentinsulzer valentinsulzer merged commit dc4855c into develop Apr 30, 2023
21 checks passed
@valentinsulzer valentinsulzer deleted the issue-2670-interp2d branch April 30, 2023 14:47
@rtimms rtimms mentioned this pull request May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offset start time when stepping Investigate xarray as backend for solution
3 participants