Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SUNDIALS version + test JaxSolver on all Python versions #2958

Merged
merged 5 commits into from May 17, 2023

Conversation

Saransh-cpp
Copy link
Member

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #2953

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@Saransh-cpp Saransh-cpp marked this pull request as draft May 16, 2023 15:39
@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -3.24 ⚠️

Comparison is base (634f7c7) 99.71% compared to head (ee35936) 96.47%.

❗ Current head ee35936 differs from pull request most recent head a8c2dd3. Consider uploading reports for the commit a8c2dd3 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2958      +/-   ##
===========================================
- Coverage    99.71%   96.47%   -3.24%     
===========================================
  Files          273      273              
  Lines        19002    19002              
===========================================
- Hits         18947    18332     -615     
- Misses          55      670     +615     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Saransh-cpp Saransh-cpp marked this pull request as ready for review May 16, 2023 18:13
@@ -22,6 +22,7 @@ deps =

commands =
tests-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu
unit-!windows-!mac: sh -c "pybamm_install_jax" # install jax, jaxlib for ubuntu
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ensures that every jax related thing in PyBaMM is unit tested on all Python versions and not just 3.9 (during coverage).

Copy link
Contributor

@martinjrobins martinjrobins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @Saransh-cpp

@martinjrobins martinjrobins merged commit 3d20678 into pybamm-team:develop May 17, 2023
19 checks passed
@Saransh-cpp Saransh-cpp deleted the fix-jax-odes branch May 17, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

scikits odes installation
2 participants