Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard variables to Thevenin() class #3143

Merged
merged 5 commits into from Jul 12, 2023

Conversation

BradyPlanden
Copy link
Member

Description

This fixes #3129.

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@BradyPlanden BradyPlanden requested a review from rtimms July 11, 2023 19:22
@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (10f9f46) 99.71% compared to head (9f2505e) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3143   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18748    18751    +3     
========================================
+ Hits         18694    18697    +3     
  Misses          54       54           
Impacted Files Coverage Δ
...full_battery_models/equivalent_circuit/thevenin.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @BradyPlanden !

@rtimms rtimms merged commit a17a5f1 into pybamm-team:develop Jul 12, 2023
19 of 21 checks passed
@BradyPlanden BradyPlanden deleted the thevenin branch July 12, 2023 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to save time data from thevenin model solution
2 participants