Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix simulation with c_rate drive cycles #3186

Merged
merged 2 commits into from Jul 24, 2023

Conversation

TomTranter
Copy link
Contributor

@TomTranter TomTranter commented Jul 24, 2023

Description

Fixes # (3185)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ pre-commit run (see CONTRIBUTING.md for how to set this up to run automatically when committing locally, in just two lines of code)
  • All tests pass: $ python run-tests.py --all
  • The documentation builds: $ python run-tests.py --doctest

You can run unit and doctests together at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (1998428) 99.71% compared to head (64a6ab1) 99.71%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3186   +/-   ##
========================================
  Coverage    99.71%   99.71%           
========================================
  Files          248      248           
  Lines        18761    18763    +2     
========================================
+ Hits         18707    18709    +2     
  Misses          54       54           
Impacted Files Coverage Δ
pybamm/simulation.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@valentinsulzer valentinsulzer merged commit 7e6a3ca into develop Jul 24, 2023
21 of 22 checks passed
@valentinsulzer valentinsulzer deleted the issue-3185-fix_c_rate_drive_cycle branch July 24, 2023 19:05
@brosaplanella brosaplanella linked an issue Jul 26, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: c_rate step with drive cycle error
2 participants