Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug where the SEI thickness decreased at some intervals when using the 'electron-migration limited' model. #3622

Merged
merged 4 commits into from Jan 18, 2024
Merged

Fixed a bug where the SEI thickness decreased at some intervals when using the 'electron-migration limited' model. #3622

merged 4 commits into from Jan 18, 2024

Commits on Dec 14, 2023

  1. The 'electron-migration limited' model has been corrected by consider… 

    …ing only negative contributions to eta_sei in the j_sei
    @kawaMANMI
    kawaMANMI committed Dec 14, 2023
    Configuration menu
    Copy the full SHA
    ed6f04d View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Update pybamm/models/submodels/interface/sei/sei_growth.py 

    Co-authored-by: Eric G. Kratz <kratman@users.noreply.github.com>
    @kawaMANMI @kratman
    kawaMANMI and kratman committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    066c340 View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Logical condition (eta_inner < 0) used instead pybamm.EqualHeaviside … 

    …for more clarity
    @kawaMANMI
    kawaMANMI committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e05da9d View commit details
    Browse the repository at this point in the history

  2. Logical condition (eta_inner < 0) used instead pybamm.EqualHeaviside … 

    …for more clarity
    @kawaMANMI
    kawaMANMI committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    3197432 View commit details
    Browse the repository at this point in the history