#738 check model option

[rtimms]

Description

Allows users to optionally skip model checks during discretisation, as this can be slow for large systems. By default the checks are performed, and it is recommended to do the model checks when developing, testing etc.

Fixes #738

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #739 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #739      +/-   ##
==========================================
+ Coverage   98.27%   98.32%   +0.04%     
==========================================
  Files         175      175              
  Lines        9351    10617    +1266     
==========================================
+ Hits         9190    10439    +1249     
- Misses        161      178      +17

Impacted Files	Coverage Δ
pybamm/discretisations/discretisation.py	99.82% <100%> (+0.11%)	⬆️
pybamm/simulation.py	89.37% <100%> (+3.75%)	⬆️
pybamm/solvers/idaklu_solver.py	86.53% <0%> (-0.72%)	⬇️
pybamm/solvers/base_solver.py	96.68% <0%> (-0.72%)	⬇️
...m/models/full_battery_models/base_battery_model.py	99.56% <0%> (-0.07%)	⬇️
pybamm/solvers/dae_solver.py	99.47% <0%> (-0.06%)	⬇️
pybamm/models/base_model.py	98.48% <0%> (-0.04%)	⬇️
pybamm/models/submodels/base_submodel.py	100% <0%> (ø)	⬆️
pybamm/expression_tree/exceptions.py	100% <0%> (ø)	⬆️
... and 4 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68539d3...10a44a3. Read the comment docs.

[Scottmar93]

Looks good, also add to simulation object as an option when solving and building?