Issue 744 particledistribution#745
Merged
valentinsulzer merged 21 commits intopybamm-team:masterfrom Dec 13, 2019
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #745 +/- ##
==========================================
+ Coverage 98.38% 98.39% +<.01%
==========================================
Files 176 176
Lines 9678 9701 +23
==========================================
+ Hits 9522 9545 +23
Misses 156 156
Continue to review full report at Codecov.
|
…PyBaMM into issue-744-particledistribution
rtimms
approved these changes
Dec 13, 2019
| Negative electrode porosity,0.3,Scott Moura FastDFN,electrolyte volume fraction | ||
| Negative electrode active material volume fraction,0.7,,assuming zero binder volume fraction | ||
| Negative particle radius [m],1E-05,Scott Moura FastDFN, | ||
| Negative particle distribution,1,, |
Contributor
There was a problem hiding this comment.
is it worth having a comment here just to make it clear that this is a size distribution in x, rather than a distribution of particle sizes at each x?
…PyBaMM into issue-744-particledistribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added particle size distribution in x to the DFN model.
Fixes #744
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: