Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#683 remove results folder and link to new repo #761

Merged
merged 2 commits into from Dec 13, 2019

Conversation

valentinsulzer
Copy link
Member

Description

Remove results folders and add some lines to READMEs to link to the new repo of results.
See new results repo here

Fixes #683

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link

codecov bot commented Dec 12, 2019

Codecov Report

Merging #761 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #761   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files         176      176           
  Lines        9678     9678           
=======================================
  Hits         9522     9522           
  Misses        156      156

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 489f90e...42cb72c. Read the comment docs.

Copy link
Contributor

@rtimms rtimms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, thanks

@rtimms
Copy link
Contributor

rtimms commented Dec 13, 2019

in the new results repo the line "- Specify (in your README) the PyBaMM version number or commit hash with which your repository works" looks to be written as code rather than text

@valentinsulzer valentinsulzer merged commit 61561b0 into master Dec 13, 2019
@valentinsulzer valentinsulzer deleted the issue-683-results branch December 13, 2019 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results folders
2 participants