Issue 858 ddt #888
Merged
Issue 858 ddt #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors if taking time derivative of *Dot classes
Codecov Report
@@ Coverage Diff @@
## develop #888 +/- ##
========================================
Coverage 97.97% 97.97%
========================================
Files 214 214
Lines 11281 11281
========================================
Hits 11052 11052
Misses 229 229 Continue to review full report at Codecov.
|
valentinsulzer
requested changes
Mar 16, 2020
| @@ -96,10 +96,10 @@ def initialise_1D(self): | |||
| inputs = {name: inp[idx] for name, inp in self.inputs.items()} | |||
| if self.known_evals: | |||
| entries[idx], self.known_evals[t] = self.base_variable.evaluate( | |||
| t, u, inputs, known_evals=self.known_evals[t] | |||
| t, u, u=inputs, known_evals=self.known_evals[t] | |||
There was a problem hiding this comment.
The first u looks especially dumb now here 🙈 (my mistake changing it a while back). But makes me wonder if we should use p= for inputs/parameters instead of u= (not for this issue)
There was a problem hiding this comment.
It certainly shouldn't be u, which is not very explanatory. p is better, although params' or parameters' would be even more obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #858.
Changes:
pybamm.VariableDotthat represents the derivative of a state variable wrt time, the time derivative of apybamm.Variableresults in apybamm.VariableDotpybamm.StateVariableDotthat represents the state time derivative vector, the time derivative of apybamm.StateVectorresults in apybamm.StateVectorDotdiscretisation of a
pybamm.VariableDotresults in a correspondingpybamm.StateVectorDotSymbol.evaluateto also take ydot, the derivative of the state vector, as an argumentpybamm.VariableDotexists in any rhs or algebraic equations (i.e. equations should be in semi-explicit form)Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: