Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 729 ecker params #922

Merged
merged 13 commits into from Mar 31, 2020
Merged

Issue 729 ecker params #922

merged 13 commits into from Mar 31, 2020

Conversation

rtimms
Copy link
Contributor

@rtimms rtimms commented Mar 27, 2020

Description

Adds the parameter set from the Ecker papers:

Ecker, Madeleine, et al. "Parameterization of a physico-chemical model of a lithium-ion battery I. determination of parameters." Journal of the Electrochemical Society 162.9 (2015): A1836-A1848.

Ecker, Madeleine, et al. "Parameterization of a physico-chemical model of a lithium-ion battery II. Model validation." Journal of The Electrochemical Society 162.9 (2015): A1849-A1857.

Fixes #729

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copy link
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@codecov
Copy link

codecov bot commented Mar 30, 2020

Codecov Report

Merging #922 into develop will increase coverage by 0.00%.
The diff coverage is 98.96%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #922   +/-   ##
========================================
  Coverage    98.03%   98.04%           
========================================
  Files          208      216    +8     
  Lines        11016    11109   +93     
========================================
+ Hits         10800    10892   +92     
- Misses         216      217    +1     
Impacted Files Coverage Δ
pybamm/parameters_cli.py 0.00% <ø> (ø)
pybamm/simulation.py 97.04% <50.00%> (-0.41%) ⬇️
pybamm/expression_tree/symbol.py 97.43% <100.00%> (ø)
...aphite_Ecker2015/graphite_diffusivity_Ecker2015.py 100.00% <100.00%> (ø)
...15/graphite_electrolyte_reaction_rate_Ecker2015.py 100.00% <100.00%> (ø)
...phite_Ecker2015/graphite_ocp_Ecker2015_function.py 100.00% <100.00%> (ø)
...es/LiNiCoO2_Ecker2015/nco_diffusivity_Ecker2015.py 100.00% <100.00%> (ø)
...ker2015/nco_electrolyte_reaction_rate_Ecker2015.py 100.00% <100.00%> (ø)
...s/LiNiCoO2_Ecker2015/nco_ocp_Ecker2015_function.py 100.00% <100.00%> (ø)
...f6_Ecker2015/electrolyte_conductivity_Ecker2015.py 100.00% <100.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 891424b...26f616f. Read the comment docs.

@valentinsulzer valentinsulzer merged commit 4dba9da into develop Mar 31, 2020
@valentinsulzer valentinsulzer deleted the issue-729-ecker-params branch March 31, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Ecker parameter set
2 participants