-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ray test #87
Fix ray test #87
Conversation
Codecov Report
@@ Coverage Diff @@
## main #87 +/- ##
==========================================
+ Coverage 97.38% 97.39% +0.01%
==========================================
Files 21 21
Lines 1299 1307 +8
==========================================
+ Hits 1265 1273 +8
Misses 34 34 |
Debugging GitHub Actions is weird 😅 Summary -
Edit: 4th and 5th point -> Use "dask[complete]" |
Thanks for your work on this. I understand that when installing dask in conda the distributed package is included. I don't particularly like the idea of pinning dask so would we fix all our problems if we just didn't test the pip install? |
Do you need to explicitly provide |
eb5e154
to
f7524df
Compare
Thanks, @wigging @TomTranter! Using "dask[complete]" worked! |
environment.yml
Outdated
@@ -27,7 +27,7 @@ dependencies: | |||
- click | |||
- autograd | |||
- absl-py | |||
- dask | |||
- dask[complete] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is dask[complete]
needed for the conda environment? Just using dask
in the environment file works fine for me. I think dask[complete]
is just needed for the pip install.
No description provided.