io module #688

lschumm · 2017-11-13T15:12:45Z

In this PR, I add the io module to Batavia.

Although one may naively implement the open() call as a standalone entity, a lot of Python depends on IO buffers–meaning that the io module is important for a lot more than files. Emulating a filesystem is very useful in porting system scripts to the browser, allowing for easy data storage (by allowing pickle or similar to write to what it wants to see, a writable file object).

PR Checklist:

All new features have been tested
All new features have been documented
I have read the CONTRIBUTING.md file
I will abide by the code of conduct

NOTE: this is in progress! Please don't merge yet :)

lschumm · 2017-11-13T15:14:41Z

Also, another note: this depends on the localstorage-fs module, which I've forked under my account because it's not very actively maintained by the original creator. I've added a direct GitHub url in the package.json to my version-I'd suggest forking that version under the pybee organization to centralize things.

brutusthebee · 2017-11-14T00:17:16Z

batavia/modules/io.js

+io.IOBase = function(args, kwargs) {
+	var types = require('../types')
+
+	PyObject.call(this)


At column 5: (no-unused-vars) 'fs' is assigned a value but never used.

brutusthebee · 2017-11-14T00:17:17Z

batavia/modules/io.js

+}
+
+create_pyclass(io.IOBase, 'IOBase')
+


At column 5: (no-unused-vars) 'version' is assigned a value but never used.

brutusthebee · 2017-11-14T00:17:17Z

batavia/modules/io.js

+create_pyclass(io.IOBase, 'IOBase')
+
+io.IOBase.__repr__ = function() {
+	return '<IOBase object at 0x99999999>'


At column 5: (no-unused-vars) 'type_name' is assigned a value but never used.

brutusthebee · 2017-11-14T00:17:17Z

batavia/modules/io.js

+
+io.IOBase.prototype.__ne__ = function(other) {
+	return this === other
+}


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:18Z

batavia/modules/io.js

+
+io.IOBase.prototype.__ne__ = function(other) {
+	return this === other
+}


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:18Z

batavia/modules/io.js

+
+io.IOBase.prototype.__ne__ = function(other) {
+	return this === other
+}


At column 6: (no-unused-vars) 'types' is assigned a value but never used.

brutusthebee · 2017-11-14T00:17:19Z

batavia/modules/io.js

+	return this === other
+}
+
+io.IOBase.prototype.close = function() {


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:19Z

batavia/modules/io.js

+	return this === other
+}
+
+io.IOBase.prototype.close = function() {


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:19Z

batavia/modules/io.js

+		this.closed = true
+	}
+	else {
+		// only the first call will have an effect; multiple close()


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:20Z

batavia/modules/io.js

+		this.closed = true
+	}
+	else {
+		// only the first call will have an effect; multiple close()


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:20Z

batavia/modules/io.js

+}
+
+io.IOBase.prototype.closed = false
+


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:21Z

batavia/modules/io.js

+}
+
+io.IOBase.prototype.closed = false
+


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:21Z

batavia/modules/io.js

+io.IOBase.prototype.fileno = function() {
+    throw new exceptions.UnsupportedOperation.$pyclass(
+        'fileno'
+    )


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:22Z

batavia/modules/io.js

+io.IOBase.prototype.fileno = function() {
+    throw new exceptions.UnsupportedOperation.$pyclass(
+        'fileno'
+    )


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:22Z

batavia/modules/io.js

+}
+
+io.IOBase.prototype.flush = function() {
+}


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:23Z

batavia/modules/io.js

+}
+
+io.IOBase.prototype.flush = function() {
+}


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:23Z

batavia/modules/io.js

+
+io.IOBase.prototype.flush = function() {
+}
+


At column 1: (indent) Expected indentation of 8 spaces but found 2 tabs.

brutusthebee · 2017-11-14T00:17:23Z

batavia/modules/io.js

+
+io.IOBase.prototype.flush = function() {
+}
+


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:24Z

batavia/modules/io.js

+io.IOBase.prototype.flush = function() {
+}
+
+// since we're in Javascript, we're not in a TTY


At column 1: (indent) Expected indentation of 8 spaces but found 2 tabs.

brutusthebee · 2017-11-14T00:17:24Z

batavia/modules/io.js

+io.IOBase.prototype.flush = function() {
+}
+
+// since we're in Javascript, we're not in a TTY


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:25Z

batavia/modules/io.js

+}
+
+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:25Z

batavia/modules/io.js

+}
+
+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:26Z

batavia/modules/io.js

+}
+
+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {


At column 2: (brace-style) Closing curly brace does not appear on the same line as the subsequent block.

brutusthebee · 2017-11-14T00:17:26Z

batavia/modules/io.js

+
+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {
+	return false


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:27Z

batavia/modules/io.js

+
+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {
+	return false


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:27Z

batavia/modules/io.js

+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {
+	return false
+}


At column 1: (indent) Expected indentation of 8 spaces but found 2 tabs.

brutusthebee · 2017-11-14T00:17:27Z

batavia/modules/io.js

+// since we're in Javascript, we're not in a TTY
+io.IOBase.prototype.isatty = function() {
+	return false
+}


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:28Z

batavia/modules/io.js

+io.IOBase.prototype.isatty = function() {
+	return false
+}
+


At column 1: (indent) Expected indentation of 8 spaces but found 2 tabs.

brutusthebee · 2017-11-14T00:17:28Z

batavia/modules/io.js

+io.IOBase.prototype.isatty = function() {
+	return false
+}
+


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:29Z

batavia/modules/io.js

+	return false
+}
+
+io.IOBase.prototype.readable = function() {


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:29Z

batavia/modules/io.js

+	return false
+}
+
+io.IOBase.prototype.readable = function() {


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:30Z

batavia/modules/io.js

+    throw new exceptions.UnsupportedOperation.$pyclass(
+        'seek'
+    )
+}


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:30Z

batavia/modules/io.js

+    throw new exceptions.UnsupportedOperation.$pyclass(
+        'seek'
+    )
+}


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:31Z

batavia/modules/io.js

+
+io.IOBase.prototype.seekable = function() {
+	return false;
+}


At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee · 2017-11-14T00:17:31Z

batavia/modules/io.js

+
+io.IOBase.prototype.seekable = function() {
+	return false;
+}


At column 2: (no-tabs) Unexpected tab character.

brutusthebee · 2017-11-14T00:17:32Z

batavia/modules/io.js

+
+io.IOBase.prototype.tell = function() {
+    throw new exceptions.UnsupportedOperation.$pyclass(
+        'seek'


At column 1: (no-trailing-spaces) Trailing spaces not allowed.

phildini · 2020-04-25T02:34:25Z

Hi there! It looks like this PR might be dead, so we're closing it for now. Feel free to re-open it if you'd like to continue, or think about directing your efforts to https://github.com/beeware/briefcase or https://github.com/beeware/toga. Both of these have more active development right now. 😄

Initial io module and IOBase class with a few example methods

826f39d

Complete IOBase methods (no binary stream functionality)

2c49a23

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

}

create_pyclass(io.IOBase, 'IOBase')

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 5: (no-unused-vars) 'version' is assigned a value but never used.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

return this === other

}

io.IOBase.prototype.close = function() {

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

}

io.IOBase.prototype.closed = false

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 1: (indent) Expected indentation of 4 spaces but found 1 tab.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

}

io.IOBase.prototype.closed = false

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

}

io.IOBase.prototype.flush = function() {

}

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

io.IOBase.prototype.flush = function() {

}

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

io.IOBase.prototype.isatty = function() {

return false

}

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

return false

}

io.IOBase.prototype.readable = function() {

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

throw new exceptions.UnsupportedOperation.$pyclass(

'seek'

)

}

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

batavia/modules/io.js

io.IOBase.prototype.seekable = function() {

return false;

}

Copy link

brutusthebee Nov 14, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At column 2: (no-tabs) Unexpected tab character.

brutusthebee reviewed Nov 14, 2017

View reviewed changes

Add rest of default io classes

4a0d35b

phildini closed this Apr 25, 2020

io module #688

io module #688

Conversation

lschumm commented Nov 13, 2017 • edited Loading

PR Checklist:

lschumm commented Nov 13, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

phildini commented Apr 25, 2020

lschumm commented Nov 13, 2017 •

edited

Loading