Add windows TimePicker Widget #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I'm not quite sure how to proceed. The tests are failing due to a few microseconds probably due to latency as they pass perfectly on my PC. @freakboy3742 Appreciate any thoughts/advice. Thanks! |
|
Removed microseconds when initial = None since I doubt anyone would care what the microseconds are on the default value. |
freakboy3742
approved these changes
Apr 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a time picking widget on Windows and related tests.
Below is the TimePicker widget in action with 11:15 AM set as the max_time and 11:00 AM set as the min_time. Also in action is the on_change automatically updated the toga label.
Overall, pretty similar in concept to the DatePicker widget with the exception of the min_time and max_time implementation not being strictly native, but it works!
PR Checklist: