This repository has been archived by the owner on May 31, 2020. It is now read-only.
[WIP] do not create __dict__s for builtin types
#880
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been stalling for the past week because I've been trying to understand why the performance gain (~1% improvement is what I've been seeing on my benchmarking test) is so modest, when this change was supposed to have a bigger effect. It turns out that creating java.util.HashMaps is not expensive at all as the table is not created until something is put in the table (a source here). In my opinion it's not worth making this change for such a small benefit, plus, then there is the need to distinguish between |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.