Skip to content

Commit

Permalink
Python 3.12b2 testing (#4695)
Browse files Browse the repository at this point in the history
* Uncomment `Interface test` sections (test_embed)

* fix: setuptools has been removed from default installs in 3.12

---------

Co-authored-by: Henry Schreiner <HenrySchreinerIII@gmail.com>
  • Loading branch information
rwgk and henryiii committed Jun 10, 2023
1 parent c679a92 commit 0e43fcc
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 12 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,9 @@ jobs:
# This makes sure the setup_helpers module can build packages using
# setuptools
- name: Setuptools helpers test
run: pytest tests/extra_setuptools
run: |
pip install setuptools
pytest tests/extra_setuptools
if: "!(matrix.runs-on == 'windows-2022')"


Expand Down Expand Up @@ -242,8 +244,6 @@ jobs:
python -m pip install -r tests/requirements.txt
- name: Configure
env:
SETUPTOOLS_USE_DISTUTILS: stdlib
run: >
cmake -S . -B build
-DCMAKE_BUILD_TYPE=Debug
Expand Down
19 changes: 10 additions & 9 deletions .github/workflows/upstream.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

name: Upstream

on:
Expand Down Expand Up @@ -65,8 +64,8 @@ jobs:
- name: Python tests C++11
run: cmake --build build11 --target pytest -j 2

# - name: C++11 tests
# run: cmake --build build11 --target cpptest -j 2
- name: C++11 tests
run: cmake --build build11 --target cpptest -j 2

- name: Interface test C++11
run: cmake --build build11 --target test_cmake_build
Expand All @@ -80,14 +79,14 @@ jobs:
-DDOWNLOAD_EIGEN=ON
-DCMAKE_CXX_STANDARD=17
- name: Build
- name: Build C++17
run: cmake --build build17 -j 2

- name: Python tests
- name: Python tests C++17
run: cmake --build build17 --target pytest

# - name: C++ tests
# run: cmake --build build17 --target cpptest
- name: C++17 tests
run: cmake --build build17 --target cpptest

# Third build - C++17 mode with unstable ABI
- name: Configure (unstable ABI)
Expand All @@ -105,10 +104,12 @@ jobs:
- name: Python tests (unstable ABI)
run: cmake --build build17max --target pytest

- name: Interface test
- name: Interface test (unstable ABI)
run: cmake --build build17max --target test_cmake_build

# This makes sure the setup_helpers module can build packages using
# setuptools
- name: Setuptools helpers test
run: pytest tests/extra_setuptools
run: |
pip install setuptools
pytest tests/extra_setuptools

0 comments on commit 0e43fcc

Please sign in to comment.