Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with std::shared_ptr<std::vector<T>> as argument in v2.2.0 #1052

Closed
pschella opened this issue Sep 1, 2017 · 2 comments · Fixed by #1054
Closed

Problem with std::shared_ptr<std::vector<T>> as argument in v2.2.0 #1052

pschella opened this issue Sep 1, 2017 · 2 comments · Fixed by #1054

Comments

@pschella
Copy link
Contributor

pschella commented Sep 1, 2017

Using std::shared_ptr<std::vector<T>> as an argument (or return value) used to work in v2.1.1, but now gives an error:

include/pybind11/cast.h:1378:5: error: static_assert failed "Holder classes are only supported for custom types" static_assert(std::is_base_of<base, type_caster<type>>::value.

@dean0x7d
Copy link
Member

dean0x7d commented Sep 1, 2017

Did this actually work or just compile in v2.1.1? As far as I know, it never worked, it's just that it was a run-time error in v2.1 and now it's a compile-time error in v2.2. There is an open issue about it: #787.

@pschella
Copy link
Contributor Author

pschella commented Sep 1, 2017

Ah, that could be. It is part of a long list of overloads that may not actually be used. Let me check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants