correct stride in matrix example and test #1103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also matches the Eigen example for the row-major case.
|
I'm slightly tired, but for an array of dimensions { rows, cols }, shoudn't the stride be either { Zcols, Z } or { Z, Zrows } depending on the storage format, but never { Z*rows, Z } (with Z = sizeof(...))? |
|
Good catch; you're quite right about the strides, and the solution looks good. I've pushed a commit to your branch that adds a couple tests that fail due to this under current master. (Once the CI tests on that pass, this is good to merge). |
Add tests with failures under current master due to the invalid strides set in the test code buffer protocol.
jagerman
force-pushed
the
correct-stride-in-matrix-example
branch
from
4ad8e7d
to
ebc8abe
Compare
|
Merged! Thanks for the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also matches the Eigen example for the row-major case.