Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug leaking function_records in cpp_function initialization in case of exceptions (found by Valgrind in #2746) #2756

Merged
merged 9 commits into from
Jan 14, 2021
Merged

Plug leaking function_records in cpp_function initialization in case of exceptions (found by Valgrind in #2746) #2756

merged 9 commits into from
Jan 14, 2021

Commits on Jan 13, 2021

  1. Plug leaking function_record objects when exceptions are thrown

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    2e39aa4 View commit details
    Browse the repository at this point in the history

  2. Plug leak of strdup'ed strings in function_record

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    39cf3b8 View commit details
    Browse the repository at this point in the history

  3. Some extra comments about the function_record ownership dance

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    69b6cb5 View commit details
    Browse the repository at this point in the history

  4. Clean up the function_record better, in case of exceptions

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    780ee72 View commit details
    Browse the repository at this point in the history

  5. Demonstrate some extra function_record leaks

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    10aad45 View commit details
    Browse the repository at this point in the history

  6. Change DeleteStrings template argument to free_strings runtime argume… 

    …nt in destruct(function_record *)
    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    dade4c9 View commit details
    Browse the repository at this point in the history

  7. Zero-state unique_function_record deleter object

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    5d5367a View commit details
    Browse the repository at this point in the history

  8. Clarify rvalue reference to unique_ptr parameter in initialize_generic

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    6578453 View commit details
    Browse the repository at this point in the history

  9. Use push_back with const char * instead of emplace_back

    @YannickJadoul
    YannickJadoul committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    1c20521 View commit details
    Browse the repository at this point in the history