py::smart_holder
std::shared_ptr
deleter simplification & optimization.
#3041
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing
guarded_builtin_delete
andguarded_custom_deleter
with a simplerguarded_delete
.The primary motivation for this change was to enable straightforward use of
std::get_deleter
, but this happened to lead to a general simplification & optimization.guarded_delete
only manages a simple function pointer and abool
.shared_ptr<bool>
is no longer needed and removed frompy::smart_holder
.This change was developed and copied from PR #3023. It sets the stage for changing
py::smart_holder
to play nicely withenable_shared_from_this
.For completeness, calling out two collateral tweaks that are not strictly needed for the deleter change: