Disabling valgrind for now. #3068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Logging a fresh observation for future reference (thanks a lot to @Yhg1s for making this possible!): Google-internal testing with (ASAN, UBSAN) x (Python 3.9) x (fastbuild, opt, dbg) is clean BUT MSAN x (Python 3.9) x (fastbuild, opt, dbg) fails, pointing to the exact same line number in Objects/typeobject.c as valgrind. See below. This makes potential root causes 4. and 5. in the PR description very unlikely. Also note that test_class_sh_trampoline_shared_from_this.py is the only failing test. I had to exclude 5 tests that need numpy/scipy/eigen, but the rest runs clean with all sanitizers. For completeness, the 5 excluded tests are: test_buffers.py, test_eigen.py, test_numpy_array.py, test_numpy_dtypes.py, test_numpy_vectorize.py. |
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Jul 10, 2021
* Using latest pytest main branch for 3.9 and 3.10. * WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 in test_class_sh_trampoline_shared_from_this.py First experiment combining two potential fixes: latest pytest, workaround. If this succeeds the next step will be to try only latest pytest without the workaround. Note: the workaround is known to resolve the MSAN error reported under pybind#3068 (comment)
rwgk
added a commit
to rwgk/pybind11
that referenced
this pull request
Jul 10, 2021
* Using latest pytest main branch for 3.9 and 3.10. * WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 in test_class_sh_trampoline_shared_from_this.py First experiment combining two potential fixes: latest pytest, workaround. If this succeeds the next step will be to try only latest pytest without the workaround. Note: the workaround is known to resolve the MSAN error reported under pybind#3068 (comment)
rwgk
added a commit
that referenced
this pull request
Jul 11, 2021
* * Rollback of PR #3068. * Using latest pytest main branch for 3.9 and 3.10. * WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 in test_class_sh_trampoline_shared_from_this.py First experiment combining two potential fixes: latest pytest, workaround. If this succeeds the next step will be to try only latest pytest without the workaround. Note: the workaround is known to resolve the MSAN error reported under #3068 (comment) * WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 = False * Narrowing down WORKAROUND_ENABLING_ROLLBACK_OF_PR3068 to Python 3.9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT 2020-07-10: This PR was rolled back with PR #3090.
Some observations:
The root cause for the error could be:
Based on the ASAN, MSAN, UBSAN testing, 1. and 2. do not seem to be the most likely root causes, although only proving what the root cause actually is can rule that out completely. Unfortunately this is likely to be very time consuming.