Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Mingw64 build and add a CI job to test it #3132

Merged
merged 6 commits into from
Jul 30, 2021
Merged

Fix Mingw64 build and add a CI job to test it #3132

merged 6 commits into from
Jul 30, 2021

Commits on Jul 30, 2021

  1. mingw64 platform string is like mingw_xxx not "mingw" 

    See https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-python/0099-Change-the-get_platform-method-in-sysconfig-and-dist.patch
    @jeromerobert
    jeromerobert committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    7e2f90e View commit details
    Browse the repository at this point in the history

  2. Mingw: Do not dllexport exceptions 

    This is a fix for errors like:

D:/a/pybind11/pybind11/include/pybind11/detail/common.h:735:23: error: 'dllexport' implies default visibility, but 'class pybind11::builtin_exception' has already been declared with a different visibility
  735 | class PYBIND11_EXPORT builtin_exception : public std::runtime_error {
      |                       ^~~~~~~~~~~~~~~~~
    @jeromerobert
    jeromerobert committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    143f9bb View commit details
    Browse the repository at this point in the history

  3. GHA: Test Mingw64 build

    @jeromerobert
    jeromerobert committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    d874307 View commit details
    Browse the repository at this point in the history

  4. fix: avoid thin binaries on mingw

    @henryiii @jeromerobert
    henryiii authored and jeromerobert committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    f7f6018 View commit details
    Browse the repository at this point in the history

  5. fix: drop lto on MinGW

    @henryiii @jeromerobert
    henryiii authored and jeromerobert committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    597119c View commit details
    Browse the repository at this point in the history

  6. Mingw64: disable PYBIND11_DEPRECATED 

    It trigger many warnings for unknown reasons
    @jeromerobert
    jeromerobert committed Jul 30, 2021
    Configuration menu
    Copy the full SHA
    12a4d2c View commit details
    Browse the repository at this point in the history