Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip down gil.h to the simple version only. #4218

Closed
wants to merge 8 commits into from
Closed

Strip down gil.h to the simple version only. #4218

wants to merge 8 commits into from

Commits on Oct 6, 2022

  1. Strip down gil.h to the simple version only.

    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7bbc06e View commit details
    Browse the repository at this point in the history

  2. Explicit py::gil_scoped_release() in test_interpreter.cpp `TEST_CAS… 

    …E("Threads")`
    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    e70b38b View commit details
    Browse the repository at this point in the history

  3. clang-tidy fix

    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7115159 View commit details
    Browse the repository at this point in the history

  4. Delete copy ctor, assignment operator also in !defined(WITH_THREAD)… 

    … section.
    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    7fc5df8 View commit details
    Browse the repository at this point in the history

  5. Use the simplified gil.h from detail/internals.h (to replace gil_scop… 

    …ed_acquire_local there).
    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    f12f194 View commit details
    Browse the repository at this point in the history

  6. Remove explicit get_internals() from TEST_CASE("Threads") and `RE… 

    …QUIRE(has_pybind11_internals_static());` along with it, based on pybind#4218 (comment)
    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    ad126f5 View commit details
    Browse the repository at this point in the history

  7. @jbms wrote: We can leave internals.tstate present (depending on ABI … 

    …version), to avoid breaking ABI compatibility. (pybind#4216 (comment))
    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    be83638 View commit details
    Browse the repository at this point in the history

  8. Correct silly mistake in previous commit. More version guards are nee… 

    …ded.
    @rwgk
    rwgk committed Oct 6, 2022
    Configuration menu
    Copy the full SHA
    b6b3ad1 View commit details
    Browse the repository at this point in the history