Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests dir has started to show up in packaging #4510

Merged
merged 1 commit into from Feb 16, 2023

Conversation

henryiii
Copy link
Collaborator

Tests have been failing due to a change (I think in setuptools) that has started including the tests folder in the SDist. We can't run the tests from outside the repo as far as I know, so let's restore the old behavior.

Description

Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! (I see the Pip workflow just succeeded.)

Did you see #4503? If we get that merged, too, we will be back to normal (and I'd want to update the smart_holder branch asap).

@henryiii henryiii merged commit 535f81a into pybind:master Feb 16, 2023
@henryiii henryiii deleted the henryiii/fix/packagingtestdir branch February 16, 2023 14:54
@henryiii
Copy link
Collaborator Author

Yes, that’s why I made this.

@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 16, 2023
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Feb 24, 2023
henryiii added a commit that referenced this pull request Feb 24, 2023
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
@rwgk rwgk mentioned this pull request Mar 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants