Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[smart_holder] git merge master #4721

Merged
merged 5 commits into from
Jun 28, 2023
Merged

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jun 27, 2023

Description

Helper/scratch PR for testing.

Suggested changelog entry:

henryiii and others added 5 commits June 21, 2023 13:25
Signed-off-by: Henry Schreiner <henryschreineriii@gmail.com>
…nd#4720)

* Trivial refactoring to make the capsule API more user friendly.

* Use new API in production code. Thanks @lalaland for pointing this out.
@rwgk
Copy link
Collaborator Author

rwgk commented Jun 28, 2023

Ignoring one frequent flake:

🐍 pypy-3.7 • windows-2022 • x64

C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.CppCommon.targets(248,5): error MSB8066: Custom build for 

@rwgk rwgk merged commit ddb677b into pybind:smart_holder Jun 28, 2023
148 of 149 checks passed
@rwgk rwgk deleted the sh_merge_master branch June 28, 2023 00:24
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Jun 28, 2023
@rwgk rwgk removed the needs changelog Possibly needs a changelog entry label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants