feat: Support move-only iterators in py::make_*iterator
#4834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wow, the new test case really is very cumbersome. Is that why you didn't cover the other two? I know I may be asking a lot, but could you try anyway? Could it make sense in this particular case to simply modify some existing key and value iterator tests? |
rwgk
approved these changes
Sep 7, 2023
|
@rwgk Thanks for the hint! I like it much better now. |
henryiii
approved these changes
Sep 7, 2023
henryiii
changed the title
py::make_*iteratorpy::make_*iterator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support heavy (move-only) iterators in
py::make_iterator,py::make_key_iterator,py::make_value_iteratorSuggested changelog entry: