-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove Python 3.7 support #5191
base: master
Are you sure you want to change the base?
Conversation
Overview of all compiler versions used/lost(
|
Tracking simple findings:
|
This reverts commit 518515a.
Revert "Try running in ubuntu:18.04 container under ubuntu-latest (to get GCC 7)" This reverts commit b203a29.
Removes two changes made under pybind#3702
This reverts commit bb5b9d1.
``` ... -- The CXX compiler identification is Clang 15.0.7 ... - Found Python: /usr/bin/python3.9 (found suitable version "3.9.2", minimum required is "3.7") found components: Interpreter Development.Module Development.Embed ... /__w/pybind11/pybind11/include/pybind11/gil.h:150:13: error: 'auto key' can be declared as 'auto *key' [readability-qualified-auto,-warnings-as-errors] auto key = internals.tstate; ^~~~~ auto * /__w/pybind11/pybind11/include/pybind11/gil.h:174:13: error: 'auto key' can be declared as 'auto *key' [readability-qualified-auto,-warnings-as-errors] auto key = detail::get_internals().tstate; ^~~~~ auto * ```
I think this next release might be a good time to remove C++11 support and increase our minimum supported compilers. |
Awesome. That's what I was thinking, too. I'll work on this PR more after the 2.13 release has baked in a bit. |
I think we can also bump CMake support. Personally, I've been going 3.15+ everywhere as that is what was required to build scikit-build-core. Though another option is 3.12+ (FindPython). I think we has someone request 3.10 or 3.11 before, might be worth checking. If we did go 3.15+, we maybe could start to phase out classic FindPythonInterp support. |
I just looked up: CMake 3.15.0 publication date was 17 July 2019 Does that look correct? — That's already 5 years ago (almost at least), and before Python 3.8 was released (Oct 2019). — I think it's much more likely to be helpful than harmful to make CMake 3.15 the minimum, and shed cruft. |
My thinking:
|
We’ve already made a 2.13 branch, master is 2.14. No rush, but waiting isn’t required. Does save ci time though if the branches are functionally identical. No need to defer cleanup, we have plenty of time for this to sit in master. We should specify and test minimum versions where possible. I’m hoping we get a MSVC bump. :) But that can also be a follow-up. |
it more prioritizing than waiting this is up high on my list though; not a lot more to do |
Description
WIP
Suggested changelog entry: