Make static internals ptr pybind version specific #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(This doesn't affect test suite .so size at all.) |
|
It's strange that gcc does that. The fix looks good to me. Might be nice to add a comment above the new function template since its purpose is a bit mysterious out of context. (As a side-note, placing |
Under gcc, the `static internals *internals_ptr` is shared across .so's, which breaks for obvious reasons. This commit fixes it by moving the static pointer declaration into a pybind-version-templated function.
jagerman
force-pushed
the
internals-ptr-fix
branch
from
a273203
to
9c9f62e
Compare
|
Added a comment, and removed the unneeded "inline". |
|
A bit of further investigation: gcc only seems to behave this way when not compiling with With |
|
Another way to fix this is to compile with |
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Jul 24, 2017
…cals This commit adds an attribute macro PYBIND11_UNSHARED_STATIC_LOCALS that forces a function to have hidden visibility under gcc. This is needed to force gcc to avoid sharing static local instances across modules (which happens even under a RTLD_LOCAL dlopen()!) This replaces the fix from pybind#862 to use this instead of the version-specific-template internals pointer.
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Jul 24, 2017
…cals This commit adds an attribute macro PYBIND11_UNSHARED_STATIC_LOCALS that forces a function to have hidden visibility under gcc. This is needed to force gcc to avoid sharing static local instances across modules (which happens even under a RTLD_LOCAL dlopen()!) This updates the workaround from pybind#862 to use this rather than the version-specific-template.
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Jul 25, 2017
…cals This commit adds an attribute macro PYBIND11_UNSHARED_STATIC_LOCALS that forces a function to have hidden visibility under gcc. This is needed to force gcc to avoid sharing static local instances across modules (which happens even under a RTLD_LOCAL dlopen()!) This updates the workaround from pybind#862 to use this rather than the version-specific-template.
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Jul 29, 2017
This commit adds a PYBIND11_UNSHARED_STATIC_LOCALS macro that forces a function to have hidden visibility under gcc and gcc-compatible compilers. gcc, in particular, needs this to to avoid sharing static local variables across modules (which happens even under a RTLD_LOCAL dlopen()!). clang doesn't appear to have this issue, but the forced visibility on internal pybind functions certainly won't hurt it and icc. This updates the workaround from pybind#862 to use this rather than the version-specific template.
jagerman
added a commit
to jagerman/pybind11
that referenced
this pull request
Aug 4, 2017
This commit adds a PYBIND11_UNSHARED_STATIC_LOCALS macro that forces a function to have hidden visibility under gcc and gcc-compatible compilers. gcc, in particular, needs this to to avoid sharing static local variables across modules (which happens even under a RTLD_LOCAL dlopen()!). clang doesn't appear to have this issue, but the forced visibility on internal pybind functions certainly won't hurt it and icc. This updates the workaround from pybind#862 to use this rather than the version-specific template.
jagerman
added a commit
that referenced
this pull request
Aug 4, 2017
This commit adds a PYBIND11_UNSHARED_STATIC_LOCALS macro that forces a function to have hidden visibility under gcc and gcc-compatible compilers. gcc, in particular, needs this to to avoid sharing static local variables across modules (which happens even under a RTLD_LOCAL dlopen()!). clang doesn't appear to have this issue, but the forced visibility on internal pybind functions certainly won't hurt it and icc. This updates the workaround from #862 to use this rather than the version-specific template.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under gcc, the
static internals *internals_ptris shared across .so's, which breaks for obvious reasons.This commit fixes it by moving the static pointer declaration into a pybind-version-templated function.
Fixes #796.