Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable detection of private operator new on MSVC #893

Merged
merged 1 commit into from
Jun 8, 2017
Merged

Enable detection of private operator new on MSVC #893

merged 1 commit into from
Jun 8, 2017

Conversation

dean0x7d
Copy link
Member

@dean0x7d dean0x7d commented Jun 8, 2017

MSVC 2015 Update 3 and 2017 can handle enough expression SFINAE to make this work now.

@dean0x7d
Enable detection of private operator new on MSVC
14e452b 
MSVC 2015 Update 3 and 2017 can handle enough expression SFINAE
to make this work now.
@jagerman
Copy link
Member

jagerman commented Jun 8, 2017

Looks good, and 👍 for moving another test of out issues.

@dean0x7d
Copy link
Member Author

dean0x7d commented Jun 8, 2017

I'm cleaning out everything in test_issues now (hopefully done soon). This was the only feature change that came out of it. It's pretty nice not to have to worry about MSVC older than 2015u3.

@dean0x7d dean0x7d merged commit e27ea47 into pybind:master Jun 8, 2017
@dean0x7d dean0x7d deleted the private-ctor branch June 8, 2017 20:30
@dean0x7d dean0x7d modified the milestone: v2.2 Aug 13, 2017
@rwgk rwgk mentioned this pull request Feb 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dean0x7d @jagerman