Fix linker issue with move constructors on MSVC #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the issue as described in the comments of commit e27ea47. This just adds `enable_if_t<std::is_move_constructible<T>::value>` to `make_move_constructor`. The change fixes MSVC and is harmless with other compilers.
dean0x7d
referenced
this pull request
Jun 23, 2017
MSVC 2015 Update 3 and 2017 can handle enough expression SFINAE to make this work now.
jagerman
approved these changes
Jun 23, 2017
|
Thanks for the confirmation @r-englund. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue as described in the comments of commit e27ea47.
This just adds
enable_if_t<std::is_move_constructible<T>::value>tomake_move_constructor. The change fixes MSVC and is harmless with other compilers. A few line breaks are also added to make the functions easier to read.@r-englund Can you verify that this fixes the issue for you?