Explicit targets not registered globally #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that targets registered for one test does not get used in another.
… registered targets
BigRoy
reviewed
Mar 9, 2020
mottosso
requested changes
Mar 20, 2020
There was a problem hiding this comment.
Taking another look at this, and my initial doubts was in changing logic.Iterator by adding the targets argument. But I think that's the way to go. Before, it kept up to date with tagets by looking globally, but that was no good. Now it's being handed targets directly, which I think is right.
Have a look at my minor notes, and then I think we can merge this. Good job.
mottosso
approved these changes
Mar 21, 2020
|
Thanks @buddly27! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #363 and #345