Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional plugin still running while toggled off #90

Closed
derrickb opened this issue Jan 25, 2017 · 8 comments
Closed

Optional plugin still running while toggled off #90

derrickb opened this issue Jan 25, 2017 · 8 comments

Comments

@derrickb
Copy link

Windows 7
Maya 2017 - PySide 2

I'm seeing a couple issues when attempting to toggle off an optional InstancePlugin that runs during the ValidatorOrder step. Seen in versions 0.7.2 and 0.7.4

  1. If I click the white box to toggle the plugin off, I get this:
    # RuntimeWarning: Invalid return value in function QAbstractListModel.setData, expected bool, got NoneType., at line 64
    in pyblish_lite\view.py

Note: this RuntimeWarning only occurs once after a fresh load of Maya.

  1. After toggling off the optional plugin (and getting the RuntimeWarning above), the plugin still runs during validation, except only one instance will fail validation, when normally 2 would fail in my test scene. So it seems to stop running after the first failing instance?
@derrickb derrickb changed the title Optional plugins still running while toggled off Optional plugin still running while toggled off Jan 25, 2017
@tokejepsen
Copy link
Member

Is it possible to post the code for the validator? Or does it fail on any validator?

@mottosso
Copy link
Member

Thanks @derrickb, having a look at this as soon as possible.

@tokejepsen, would you have a moment to look at this? I'm out of the country for a few weeks.

@mottosso
Copy link
Member

Ah, just saw you had already commented :)

@derrickb
Copy link
Author

I did some more testing and I am now fairly certain that this is limited to the first optional validator as seen in the GUI's list:
image

Notice how even though my "NonManifoldGeo" plugin is turned off, the first pSphere1 mesh still passes. Before, my "UnshadedFaces" plugin was first in the list. pShere1 is expected to fail this validator (I can't post its full code as it is not mine), and indeed it does fail even though the plugin is turned off.

image

@tokejepsen
Copy link
Member

What order is your validators?

@mottosso
Copy link
Member

Thanks @derrickb, I think the problem is related to #59.

The solution I have in mind involves removing the ability to pause and continue an ongoing publish. It's a rather complex feature and I haven't yet come across any feasible alternative solution to.

@derrickb
Copy link
Author

@tokejepsen I'm using order = pyblish.api.ValidatorOrder

@mottosso thanks for the reply, hope it's something that can get resolved soon. I'm going to try having a dummy plugin as the first in the list to see if I can use the rest as intended.

@mottosso
Copy link
Member

Closing this, it will be resolved alongside #59.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants