Use bytes to represent filter in bluez, fix #317 #452
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I try to use beacontools to scan for Eddystone beacons, but encountered exact the same problem as in issue #317.
Another possible byte vs. unicode issue in bluez bindings I spot is function
hci_send_cmd()
. Its paramterparams
need to passed as bytes produced bystruct
module, but parsed as string (s#
). Considering possible usage regressions it might bring, I didn't put its fix in this PR.