Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhemexDataStoreで認証エラーのWarningを表示する #114

Closed
1 task done
MtkN1 opened this issue Jan 5, 2022 · 0 comments
Closed
1 task done

PhemexDataStoreで認証エラーのWarningを表示する #114

MtkN1 opened this issue Jan 5, 2022 · 0 comments
Assignees
@MtkN1
Labels
enhancement New feature or request

Comments

@MtkN1
Copy link
Member

MtkN1 commented Jan 5, 2022 •
edited

課題

PhemexのWebSocketで認証エラーが発生してもユーザーは検知する事が難しい。
認証エラーを受信したらloggingでWarningを表示する。

Discordより:
https://discord.com/channels/832651305155297331/832653694839160892/928235886448099349

実装

下記のようなエラーメッセージが受信される。
{'error': {'code': 6012, 'message': 'invalid login token'}, 'id': 123, 'result': None}
JSONに error キーがあれば警告を出す。

チェックリスト

  • 実装
@MtkN1 MtkN1 added the enhancement New feature or request label Jan 5, 2022
@MtkN1 MtkN1 self-assigned this Jan 5, 2022
MtkN1 added a commit that referenced this issue Jan 5, 2022
@MtkN1
Display error warnings in PhemexDataStore (#114)
2eb1117
@MtkN1 MtkN1 mentioned this issue Feb 4, 2022
Merged
MtkN1 added a commit that referenced this issue Feb 4, 2022
@MtkN1
Merge pull request #128 from MtkN1/develop
4174779 
✨v0.10.0リリース

## Issues

✅ 各取引所のDataStoreを実装する #20
✅ DataStoreのリバースイテレーション可能にする #113
✅ PhemexDataStoreで認証エラーのWarningを表示する #114
✅ BybitInverseDataStoreにwalletを追加する #118
✅ GMOCoinDataStoreのtickerが上書きされない #120
✅ GMOCoinDataStoreがTypeErrorで落ちる。 #122
✅ GMOコインのPrivate WebSocketアクセストークンを自動延長する #124
✅ bitbankのDatastoreのDepthで、sorted()の返り値の型の定義が正しくない #126
@MtkN1 MtkN1 closed this as completed Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MtkN1 MtkN1

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MtkN1