Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bybit DataStoreのKline(ローソク足)のキーが足りていない #62

Closed
MtkN1 opened this issue Jun 21, 2021 · 0 comments
Closed

Bybit DataStoreのKline(ローソク足)のキーが足りていない #62

MtkN1 opened this issue Jun 21, 2021 · 0 comments
Assignees
@MtkN1
Labels
bug Something isn't working

Comments

@MtkN1
Copy link
Member

MtkN1 commented Jun 21, 2021

課題

pybotters.BybitDataStore.kline のキーについて

現状
['symbol', 'start']

修正後
['symbol', 'period', 'start']

時間足のキーがないので、複数時間足を購読しているとstartが被ると上書きされてしまう状態。
endでもいいが折角なのでperiodを追加してfindできるようにする。
@MtkN1 MtkN1 added the bug Something isn't working label Jun 21, 2021
@MtkN1 MtkN1 self-assigned this Jun 21, 2021
MtkN1 added a commit that referenced this issue Jun 21, 2021
@MtkN1
Fix Bybit DataStore Kline key (#62)
3938a2a
@MtkN1 MtkN1 mentioned this issue Jun 21, 2021
Merged
MtkN1 added a commit that referenced this issue Jun 21, 2021
@MtkN1
Merge pull request #65 from MtkN1/develop
6244c5f 
✨v0.4.1リリース

✅Binanceのイベント仕様に従ってDataStoreを更新する #58
✅Bybit DataStoreのKline(ローソク足)のキーが足りていない #62
✅DataStoreにおいてWebSocketエラーメッセージのWarningを表示する #63

✅Python 3.7以外のテストが通っていない #51
✅Linter, Formatter を導入したい #59
@MtkN1 MtkN1 closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MtkN1 MtkN1

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MtkN1