Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve WebScoket auth #262

Merged
merged 2 commits into from Jan 18, 2024
Merged

Improve WebScoket auth #262

merged 2 commits into from Jan 18, 2024

Conversation

MtkN1
Copy link
Member

@MtkN1 MtkN1 commented Jan 18, 2024

Summary

WebSocket の認証周りのコードを改善、バグ修正します。

またテストコード向上により ws.py のテストカバレッジが 100 % になります 🎊🎊 (これで models/ 以外のカバレッジは全て 100 % です!)

Changes

  • Remove: 廃止されている Bybit V1 Spot の WebSocket 認証を削除します
  • Modify: 全取引所の WebSocket の認証待ちコードについて、認証失敗時に永久待機を避ける仕様に統一します
  • Modify: 非 JSON の "ping", "pong" 文字列の JSON デコードエラーによる Warning ログを抑制します
  • Fix: KuCoin の WebSocket ホスト名を最新化します
  • Fix: Phemx の WebSocket ホスト名を最新化します
  • Fix: Binance の "WebSocket API" でメッセージに "params" がない場合認証されないバグを修正します
  • Fix: WebSocket 側の Binance Spot Testnet の API 名が Improve Binance Authentication #256 に追随していない問題を修正します
  • Improve: ws.py のテスト向上により、基盤部分のテストカバレッジが 100 % になります🎊🎊
    image

@MtkN1 MtkN1 self-assigned this Jan 18, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5e19be2) 55.79% compared to head (aab8f68) 59.51%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
+ Coverage   55.79%   59.51%   +3.72%     
==========================================
  Files          18       18              
  Lines        3126     3100      -26     
==========================================
+ Hits         1744     1845     +101     
+ Misses       1382     1255     -127     
Flag Coverage Δ
unittests 59.51% <100.00%> (+3.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MtkN1 MtkN1 merged commit c204d7a into main Jan 18, 2024
11 checks passed
@MtkN1 MtkN1 deleted the improve-ws-tests branch January 18, 2024 06:04
This was referenced Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants